Remove legacy JSON code #1356
Merged
Remove legacy JSON code #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust for namespace `vast::format::json` and modify json import integration tests to be based on simdjson.
This is a backup commit which stores a compilable version. Writer test fails and some other tests are temporary disabled.
Co-authored-by: Dominik Lohmann <mail@dominiklohmann.de>
dominiklohmann
force-pushed
the
story/ch4981/legacy-json-removal
branch
from
f59dbb4
to
626dc89
Compare
tobim
approved these changes
Feb 8, 2021
They are both covered by integration tests. The example plugin integration test checks |
3 tasks
tobim
reviewed
Feb 8, 2021
| @@ -13,6 +13,20 @@ This changelog documents all notable user-facing changes of VAST. | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### ⚡️ Breaking Changes | |||
There was a problem hiding this comment.
Nope, that was definitely a mistake. Can you remove this in your other PR that's likely next to be merged?
There was a problem hiding this comment.
The one for the partition_selector is probably next, but that doesn't touch the changelog. I'll remove it in the PR that moves around the options.
tobim
added a commit
that referenced
this pull request
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
This PR fixes up @ngrodzitski's work in #1343 so we can merge it into master.
📝 Checklist
🎯 Review Instructions
Commit-by-commit.