New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud matchers #2473
Merged
Merged
Cloud matchers #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO:
|
rdettai
force-pushed
the
story/sc-35289/cloud-matchers
branch
6 times, most recently
from
August 13, 2022 08:25
3a0125a
to
bc4d05c
Compare
rdettai
force-pushed
the
story/sc-35289/cloud-matchers
branch
from
August 16, 2022 14:12
c0f43a5
to
d1685b4
Compare
2 tasks
@dispanser don't review the docs to harshly, I will actually bring another batch of improvements to it in #2510 馃槈 |
dispanser
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and was able to see matching events in the SQS queue. Thanks!
A remark and a spelling correction in the comments :)
rdettai
force-pushed
the
story/sc-35289/cloud-matchers
branch
from
August 24, 2022 08:38
9f29769
to
82de3b8
Compare
rdettai
force-pushed
the
story/sc-35289/cloud-matchers
branch
from
August 25, 2022 06:57
82de3b8
to
e6fb8f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offer out of the box matchers from external datasources (Abuse Feodo Tracker, Pulsedive). The matches are published to an SQS queue by a matcher-client service running on fargate.
馃摑 Checklist
馃幆 Review Instructions
Start the review by checking out the new documentation
I have fixed a few issues I encountered along the development of the feature:
common.py
as we have both a vast-server and a matcher-client task now