Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove many deprecated things #4103

Merged
merged 6 commits into from Apr 7, 2024
Merged

Conversation

dominiklohmann
Copy link
Member

@dominiklohmann dominiklohmann commented Apr 6, 2024

This removes quite a few things that have long been deprecated:

  • The count command that is superseded by export | summarize count(.)
  • The status command and /status endpoint (although not yet the status handlers from all components, which is a lot more effort), which are superseded by show
  • The remote command infrastructure that is unused with the removal of the status command
  • The aging mechanism that has long been superseded by compaction and was undocumented for over a year now
  • The corelight-cat script that I don't think anyone has ever used, and that not needed with the new TCP connector changes anymore
  • The old Docker Compose setup that was split into multiple files that was superseded with the setup in the repository root

@dominiklohmann dominiklohmann added maintenance Tasks for keeping up the infrastructure engine Core pipeline and storage engine labels Apr 6, 2024
This removes the deprecated `tenzir-ctl status` and `api /status`
entirely. They have long been superseded by the `show` operator that can
stream large amounts of information much more efficiently.
This has been superseded by compaction for the longest time and just
hasn't been removed yet. This finally takes care of the removal. The
documentation for this was already deleted a year back.
The `count` command has long been deprecated alongside everything else
in `tenzir-ctl`. As we are inching closer towards the rewrite of
Tenzir's storage engine in a dedicated plugin, it is now time to remove
the old commands that interacted with it.
With recent improvements to `from tcp` from #4084 this script is no
longer needed.
The new setup in the repository root has been the setup to use for a
while now, but nobody so far bothered to clean this up.
@dominiklohmann dominiklohmann added the packaging Relating to the build scaffold label Apr 7, 2024
Copy link
Member

@mavam mavam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refreshing!

@dominiklohmann dominiklohmann merged commit ea2d358 into main Apr 7, 2024
51 checks passed
@dominiklohmann dominiklohmann deleted the topic/reomve-deprecated-things branch April 7, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine Core pipeline and storage engine maintenance Tasks for keeping up the infrastructure packaging Relating to the build scaffold
Projects
None yet
2 participants