Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow output format selection for the pivot/explore command #921

Merged
merged 6 commits into from Jul 1, 2020
Merged

Allow output format selection for the pivot/explore command #921

merged 6 commits into from Jul 1, 2020

Conversation

dominiklohmann
Copy link
Member

No description provided.

@dominiklohmann dominiklohmann added the feature New functionality label Jun 15, 2020
@dominiklohmann dominiklohmann mentioned this pull request Jun 23, 2020
Merged
@dominiklohmann dominiklohmann changed the title Allow output format selection for the pivot command Allow output format selection for the pivot/explore command Jun 23, 2020
@dominiklohmann dominiklohmann marked this pull request as ready for review June 23, 2020 09:26
@dominiklohmann dominiklohmann requested a review from a team June 23, 2020 09:27
lava
lava approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@lava lava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The matcher might need the same treatment when this is bumped to vast-pro.

@dominiklohmann
Copy link
Member Author

The matcher might need the same treatment when this is bumped to vast-pro.

That's a good point, thanks!

@dominiklohmann dominiklohmann merged commit 2e61855 into master Jul 1, 2020
@dominiklohmann dominiklohmann deleted the story/ch17512 branch July 1, 2020 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lava lava lava approved these changes

Assignees
No one assigned
Labels
feature New functionality
Projects
None yet
Milestone
No milestone
2 participants
@dominiklohmann @lava