Factor common functionality in component plugin #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiklohmann
force-pushed
the
story/ch23936/component-plugin
branch
from
f9e4ab0
to
38c58c3
Compare
mavam
approved these changes
Apr 12, 2021
Yes. I've ported our proprietary analyzer plugins for testing this. Only thing that really changed is the ownership model: The analyzers are now owned by the NODE directly rather than the IMPORTER. |
dominiklohmann
force-pushed
the
story/ch23936/component-plugin
branch
2 times, most recently
from
e179c62
to
4d8d454
Compare
It turns out that just having a handle to the NODE is already a valuable plugin. Such a plugin can spawn an actor and register itself with the NODE. That's it. Other plugins, like the analyzer plugin, will then inherit from this plugin. The component plugin only gives you the node actor and requires that you implement the status subscriber.
dominiklohmann
force-pushed
the
story/ch23936/component-plugin
branch
from
4d8d454
to
cc48861
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📔 Description
It turns out that just having a handle to the NODE is already a valuable plugin. Such a plugin can spawn an actor and register itself with the NODE. That's it.
Other plugins, like the analyzer plugin, will then inherit from this plugin.
The component plugin only gives you the node actor and requires that you implement the status subscriber.
📝 Checklist
🎯 Review Instructions
File-by-file.