Use ID for notification object if passed to addNotification method #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onNotificationRemoval passes ID, which needs to be identified for identifying the correct notification object to remove from react redux state
|
Code looks ok although it's not clear for me why haven't you been using the id returned by |
|
I have list of notification objects in state and after notification is hidden, I would like to remove from the state array. For doing this I need to identify which object to be removed. Since the random generated ID is passed, it's not possible to identify the correct notification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently random ID is generated for notification and is passed on onNotificationRemoval. Using this random ID we cannot identify the notification object in redux state for cleaning. So I have passed the ID generated by app and used for creating notification object.