Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass classname and id to root component #31

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Pass classname and id to root component #31

merged 1 commit into from
Nov 4, 2019

Conversation

sradevski
Copy link
Contributor

Fixes #30

@teodosii
Copy link
Owner

Why bother with otherProps when you could destructure this.props inside the two renderers? I will merge the PR only after this change.

@teodosii
Copy link
Owner

teodosii commented Oct 3, 2019

Also we need to update readme to let people know about the change, otherwise it's kinda pointless

@sradevski
Pass classname and id to root component
141eeec 
Signed-off-by: Stevche Radevski <stevche@balena.io>
@sradevski
Copy link
Contributor Author

@teodosii addressed the comments, have another look at it

@teodosii
Copy link
Owner

teodosii commented Oct 9, 2019

Looks good, will merge it

@teodosii teodosii merged commit f93abe3 into teodosii:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass classname and id to notification component
2 participants
@sradevski @teodosii