Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Release Notes by Extracting Module Descriptor Logic #79

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

teogor
Copy link
Owner

@teogor teogor commented Apr 17, 2024

Improved Module Descriptor Collection for Release Notes

This pull request refactors the code responsible for collecting module descriptors within the ReleaseNotesTask.

Previously:

  • The code directly accessed properties from the winds object within the collectModuleDescriptors function.
  • This nested multiple levels of property access and object calls, making the logic less readable.

Changes:

  • The logic for building a ModuleDescriptor has been extracted into a separate function called buildModuleDescriptor.
  • The collectModuleDescriptors function now delegates the descriptor creation to this new function for both the main project and its subprojects.
  • This improves code readability by separating concerns and reducing nested calls.

@teogor teogor added @enhancement New feature or request @environment labels Apr 17, 2024
@teogor teogor added this to the 1.0.1 milestone Apr 17, 2024
@teogor teogor self-assigned this Apr 17, 2024
@teogor teogor merged commit 786d7cb into main Apr 17, 2024
5 checks passed
@zeobot zeobot bot deleted the module-descriptor-clarity branch April 17, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@enhancement New feature or request @environment
Projects
Development

Successfully merging this pull request may close these issues.

1 participant