Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use the default bridge network list as it's problematic #262

Closed
hoatle opened this issue Feb 15, 2017 · 5 comments
Closed

don't use the default bridge network list as it's problematic #262

hoatle opened this issue Feb 15, 2017 · 5 comments

Comments

@hoatle
Copy link
Member

hoatle commented Feb 15, 2017

the list is not correct for many cases, we should find a way for auto select precisely.

hoatle [6:36 PM] 
cái default bridge network của mình cần update, như hiện tại chị @phuongdt dùng LAN có interface là: `en4: Apple USB Ethernet Adapter` mà ko có trong list, vagrant theo config của mình lại lấy interface wifi, nên bị stuck ở đoạn set networks

[6:36]  
giờ mình thêm `en4: Apple USB Ethernet Adapter` vào đầu list hay là remove toàn bộ default đi nhỉ, hoặc tìm cách check active interface mới connect

phuonglm [6:37 PM] 
linux ma khong co trong list no’ hoi

hoatle [6:37 PM] 
ko biết cách check interface đó có được không, tạm thời workaround bên chị Phương kia là remove list và chọn interface. Việc chọn interface này sẽ confused với nhiều người dùng, nên cách tốt nhất là tìm cách select tự động chính xác

[6:38]  
để e tạo issue improve rồi tìm cách
@hoatle hoatle added this to the v0.5.0-b2 milestone Feb 15, 2017
@hoatle hoatle changed the title should update the default bride network interface list should select the right bridge network interface Feb 15, 2017
@hoatle hoatle changed the title should select the right bridge network interface should select the right bridge network interface automatically Feb 15, 2017
@hoatle
Copy link
Member Author

hoatle commented Feb 16, 2017

when vagrant up get stuck at network settings, we have this workaround:

adjust the vagrant_config_override.json with the following settings (clean the network interface list):

{
  "vm": {
    "networks": [{
      "_id": "0",
      "bridge": []
    }]
  }
}

and $ vagrant up again, choose the right network interface.

@hoatle
Copy link
Member Author

hoatle commented Feb 16, 2017

related: hashicorp/vagrant#655

@hoatle hoatle changed the title should select the right bridge network interface automatically should select the right bridged network interface automatically Feb 16, 2017
@hoatle
Copy link
Member Author

hoatle commented Feb 22, 2017

this is very critical now, I see lots of problems come from the bride list, let's remove the list, make users to choose manually first.

@hoatle
Copy link
Member Author

hoatle commented Feb 22, 2017

this is problematic when:

  • someone is using both LAN and wifi (Mac + Linux). And the inactive interface on the list was chosen and causes the problem that vagrant up hangs at the network settings step.

@hoatle hoatle assigned hoatle and unassigned phuonglm Feb 24, 2017
@hoatle hoatle changed the title should select the right bridged network interface automatically don't use the default bridge network list as it's problematic Feb 24, 2017
@hoatle
Copy link
Member Author

hoatle commented Feb 24, 2017

so the new behavior follows:

  • vagrant will ask users to choose the right network interface (1 is usually the active interface) if there are 2 or more interfaces. In this case, users should know the right network interface and add it into their bride list (by overriding the default bridge list)

for example:

{
  "vm": {
    "networks": [{
      "_id": "0",
      "bridge": [
        "en0: Wi-Fi (AirPort)"
      ]
    }]
  }
}
  • if there is only 1 network interface, vagrant will choose it automatically without asking

hoatle added a commit to hoatle/teracy-dev that referenced this issue Feb 24, 2017
hoatle added a commit that referenced this issue Mar 1, 2017
@ #262 | don't use the default bridge network list as it's problematic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants