-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should have json config support docker registry login #295
Comments
we should not put credentials into the config file, better to use prompt for username/password or at least use environment variable. |
update: no username/password prompt. |
environment variable: move out of this issue. |
datphan
added a commit
to datphan/dev
that referenced
this issue
Jun 19, 2017
datphan
added a commit
to datphan/dev
that referenced
this issue
Jun 19, 2017
Merged
ghost
assigned hoatle
Jun 20, 2017
datphan
added a commit
to datphan/dev
that referenced
this issue
Jul 13, 2017
datphan
added a commit
to datphan/dev
that referenced
this issue
Jul 19, 2017
verified, close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is considered a new feature, we should not introduce new feature after beta releases.
However, this is a really critical one so we break that rule with this.
The config should be something like:
add a Chef recipe like:
Anyone who needs this for v0.5.0-b2 and below, you can follow the instruction above to add this config and port this Chef recipe into your dev setup project.
The text was updated successfully, but these errors were encountered: