Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctrl-c did not always terminate the vagrant running process #532 #607

Merged
merged 1 commit into from Jul 25, 2019
Merged

ctrl-c did not always terminate the vagrant running process #532 #607

merged 1 commit into from Jul 25, 2019

Conversation

phuonglm
Copy link
Contributor

Connect #532

@phuonglm phuonglm requested review from hoavt and datphan June 10, 2019 01:15
datphan
datphan previously approved these changes Jun 10, 2019
View reviewed changes
@hoatle hoatle added this to Under Review in public-dev via automation Jun 11, 2019
hoavt
hoavt reviewed Jun 12, 2019
View reviewed changes
Copy link
Contributor

@hoavt hoavt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phuonglm Please check my comments.

docs/getting_started.rst Outdated

- Also please make sure ``echo $VAGRANT_PREFER_SYSTEM_BIN`` return ``true``, if not then add it by ``echo "export VAGRANT_PREFER_SYSTEM_BIN=true" >> ~/.bashrc"``

- After finished, restart the machine.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--> Restart the machine after the installation is finished.

@hoatle hoatle assigned phuonglm and unassigned hoavt Jun 13, 2019
@phuonglm phuonglm assigned hoavt and unassigned phuonglm Jun 27, 2019
hoavt
hoavt reviewed Jul 4, 2019
View reviewed changes
Copy link
Contributor

@hoavt hoavt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phuonglm please check my comment.

docs/getting_started.rst Outdated Show resolved Hide resolved
@hoatle hoatle assigned phuonglm and unassigned hoavt Jul 5, 2019
@phuonglm phuonglm assigned hoavt and unassigned phuonglm Jul 25, 2019
@hoatle hoatle merged commit 0e113fd into teracyhq:develop Jul 25, 2019
public-dev automation moved this from Under Review to Done Jul 25, 2019
@hoatle hoatle linked an issue Feb 21, 2020 that may be closed by this pull request
ctrl-c did not always terminate the vagrant running process #532
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoavt hoavt hoavt approved these changes

@datphan datphan datphan left review comments

Assignees

@hoavt hoavt

Labels
None yet
Projects
public-dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ctrl-c did not always terminate the vagrant running process
4 participants
@phuonglm @hoavt @datphan @hoatle