Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl-c did not always terminate the vagrant running process #532

Closed
hoatle opened this issue Oct 31, 2018 · 14 comments · Fixed by #607
Closed

ctrl-c did not always terminate the vagrant running process #532

hoatle opened this issue Oct 31, 2018 · 14 comments · Fixed by #607

Comments

@hoatle
Copy link
Member

hoatle commented Oct 31, 2018

and it causes errors, especially on Windows - Cygwin, for example, running some vagrant commands did not work). We need to investigate the root cause.

related:

@hieptranquoc
Copy link

hieptranquoc commented Dec 7, 2018

Root cause: Mintty was failed when running as background process! It will ignore SIGNALS( SIGINT, SIGKILL, SIGTERM ). I still have no way to solve this problem! I need to discuss to resolve the problem.

@hieptranquoc
Copy link

hieptranquoc commented Dec 11, 2018

The problem is that the mintty is not fully compatible with the window.
Related:
https://mintty.github.io/mintty.1.html#LIMITATIONS
mintty/mintty#56
https://github.com/mintty/mintty/wiki/Tips#inputoutput-interaction-with-alien-programs

Should use winpty in mintty, it will resolve this problem!
Install winpty ( https://github.com/rprichard/winpty )
Or
can be fix by follow step:

  1. install ruby for cygwin ( by cygwin packages installer )
    2 install ruby for window
    3 add ruby Path
    4 add cygwin/bin, sbin, usr/local/bin, usr/sbin, usr/bin to PATH
    5 And the most important thing is: Install git (https://git-scm.com/), and use git-bash instead of cygwin-terminal ( mintty will be integrated in git-bash )

****** TESTED *******
It will work!
Done!

@hoatle
Copy link
Member Author

hoatle commented Dec 11, 2018

so we need to use git-bash instead of cygwin
related: #563

@hoatle
Copy link
Member Author

hoatle commented Jan 17, 2019

assigned to @phuonglm to check and confirm on this.

If this bug only happens on Cygwin, not Git-Bash, then Git-Bash is preferred to use and we'll deprecate Cygwin when Git-Bash is proven to be stable and better than Cygwin.

@hoatle hoatle removed their assignment Jan 17, 2019
@hoatle hoatle assigned hoavt and unassigned phuonglm Feb 21, 2020
@hoatle hoatle moved this from Under Verification to Under Review in public-dev Mar 16, 2020
@hoatle hoatle moved this from Under Review to In progress in public-dev Mar 16, 2020
@hoatle hoatle moved this from In progress to Sprint-Current in public-dev Mar 16, 2020
@hoatle hoatle assigned phuonglm and unassigned hoavt Mar 16, 2020
@hoatle
Copy link
Member Author

hoatle commented Mar 16, 2020

@hieptranquoc said that it looked like the problem is fixed on the recent latest version of cygwin, need @phuonglm to verify on this. If so, we don't need to use the wrapper anymore.

@hoatle hoatle moved this from Sprint-Current to Sprint-Next in public-dev Apr 1, 2020
@hoatle hoatle moved this from Sprint-Next to Sprint-Current in public-dev Apr 6, 2020
@phuonglm
Copy link
Contributor

phuonglm commented Apr 7, 2020

@hieptranquoc, I clean install windows 7 x64 cygwin and vagrant 2.2.4, virtualbox 6.0.8 but still got the problem with ctrl+c, could you specify more details about your version
Screen Shot 2020-04-07 at 11 53 53

@hoatle hoatle assigned hieptranquoc and unassigned phuonglm Apr 7, 2020
@hieptranquoc
Copy link

@hieptranquoc, I clean install windows 7 x64 cygwin and vagrant 2.2.4, virtualbox 6.0.8 but still got the problem with ctrl+c, could you specify more details about your version
Screen Shot 2020-04-07 at 11 53 53

I ran with window 10 - x64. If windows 7 and windows 8 can not use mintty, you need to confirm that and the solution is switch to another tty!

@hoatle hoatle assigned phuonglm and unassigned hieptranquoc Apr 7, 2020
@hoatle
Copy link
Member Author

hoatle commented May 6, 2020

assign to @hoavt to verify the current (workaround) solution.

@hoatle hoatle assigned hoavt and unassigned phuonglm May 6, 2020
@hoatle hoatle moved this from Sprint-Current to Under Verification in public-dev Jun 2, 2020
phuonglm added a commit to phuonglm/dev that referenced this issue Jun 9, 2020
hoatle added a commit that referenced this issue Jun 10, 2020
ctrl-c did not always terminate the vagrant running process #532 - fi…
@hoatle hoatle assigned phuonglm and unassigned hoavt Jul 2, 2020
@hoatle
Copy link
Member Author

hoatle commented Jul 2, 2020

assigned to @phuonglm to verify and confirm.

@phuonglm
Copy link
Contributor

Verified on windows 7 and windows 10 x64 when used winpty as alias and everything work as expected.

@hoatle
Copy link
Member Author

hoatle commented Jul 13, 2020

closed, thank you.

@hoatle hoatle closed this as completed Jul 13, 2020
public-dev automation moved this from Under Verification to Done Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
public-dev
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants