Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relp rebind feature #64

Closed
kortemik opened this issue May 14, 2024 · 1 comment · Fixed by #66
Closed

relp rebind feature #64

kortemik opened this issue May 14, 2024 · 1 comment · Fixed by #66
Assignees
Labels
assistance Extra attention, more information or help is needed

Comments

@kortemik
Copy link
Member

Description
currently relp connections use a persistent connection that is once established and will only be established on an error. this is good performance wise for lsh_01 but for balancing queues relp server that receives data this is not sufficient.

Use case or motivation behind the feature request
in case multiple lsh_01 instances end up into a single relp server by a network load balancer bad decisions, this will cause the said relp server to receive all the traffic and rest of the load balancer target servers none and therefore the performance will be degraded.

Related issues

Additional context

@kortemik kortemik added the assistance Extra attention, more information or help is needed label May 14, 2024
@kortemik
Copy link
Member Author

kin_02 might have this implemented with rlp_01

kortemik pushed a commit that referenced this issue May 24, 2024
…s have been sent (#66)

* Open a new RELP connection after a certain amount of messages have been sent with it. Two new configuration parameters for rebinding.

* Refactor counting sent records to IRelpConnection

* Add more rebind tests for RelpConnectionPool

* Refactor rebinding to a decorator, use generic Pool with managedRelpConnection

* Remove unnecessary function already defined in extending interface, apply spotless

* Add test for rebind

* Remove unnecessary functions from IManagedRelpConnection interface, create new rebind tests

* Change ManagedRelpConnection to only follow has been a connection made atleast once and not the connection itself. Change counter in CountingFrameDelegate to AtomicInteger.

* Fix hasConnected in ManagedRelpConnection

* Add tests for invalid rebindRequestAmount system property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assistance Extra attention, more information or help is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants