Fix #64: Rebind RELP connections after configurable amount of messages have been sent #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en sent with it. Two new configuration parameters for rebinding.
kortemik
requested changes
May 16, 2024
|
perhaps this kind of kortemik@80b5ee1 could be used for a generic pool? |
Closed
kortemik
requested changes
May 20, 2024
kortemik
reviewed
May 22, 2024
src/main/java/com/teragrep/lsh_01/pool/IManagedRelpConnection.java
Outdated
Show resolved
Hide resolved
src/main/java/com/teragrep/lsh_01/pool/RebindableRelpConnection.java
Outdated
Show resolved
Hide resolved
src/main/java/com/teragrep/lsh_01/pool/RelpConnectionFactory.java
Outdated
Show resolved
Hide resolved
…reate new rebind tests
kortemik
requested changes
May 23, 2024
src/test/java/com/teragrep/lsh_01/util/CountingFrameDelegate.java
Outdated
Show resolved
Hide resolved
…e atleast once and not the connection itself. Change counter in CountingFrameDelegate to AtomicInteger.
StrongestNumber9
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new configuration properties:
relp.rebindRequestAmountwith a default of one million andrelp.rebindEnabledwith the default value false.RelpConnectionPool keeps count of sent messages for each connection with a HashMap, and gives out a new connection when the
rebindRequestAmountof sent messages is reached.