Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #53: Enable end-to-end testing, new test cases #65

Merged
merged 3 commits into from
May 16, 2024

Conversation

51-code
Copy link

@51-code 51-code commented May 15, 2024

Enables end-to-end testing:

  • RelpServer provides methods for tests to start up and close the RelpServer.
  • RelpServer stores all payloads, that can be retrieved by the test after the HTTP request is made. The payloads are cleared after each test.

New tests for:

  • End-to-end tests for payload regex splitting
  • Testing the NPE from no auth causes npe #50
  • Sending multiple requests in a row

Questions/worries:

  • More test cases ?
  • Should the Thread running Main be closed somehow after tests?
  • Should there be testing for correctness of HTTP-headers in the payloads?
  • Is end-to-end testing sufficient for RelpConvertion? I find it difficult to create unit tests for it.

… splitting, multiple requests and null headers.
@51-code 51-code added assistance Extra attention, more information or help is needed enhancement New feature or request labels May 15, 2024
@51-code 51-code requested a review from kortemik May 15, 2024 06:56
@51-code 51-code self-assigned this May 15, 2024
@51-code 51-code mentioned this pull request May 15, 2024
src/test/java/EndToEndTest.java Show resolved Hide resolved
src/test/java/com/teragrep/lsh_01/util/RelpServer.java Outdated Show resolved Hide resolved
src/test/java/com/teragrep/lsh_01/util/RelpServer.java Outdated Show resolved Hide resolved
@51-code
Copy link
Author

51-code commented May 16, 2024

Implemented requested changes.

@kortemik kortemik merged commit 0126474 into teragrep:main May 16, 2024
1 check passed
@51-code 51-code deleted the fix_#53 branch June 3, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assistance Extra attention, more information or help is needed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants