Merge 0993a5d into cc85156

src/middleware/getImageUrl.js

@@ -9,7 +9,11 @@ const safeSet = require('lodash.set')
 const sources = require(path.join(__dirname, '..', 'sources', 'index'))
 
 module.exports = function getImageUrl (req, res, next) {
-  Promise.resolve(sources[req.params.source](req.params.user))
+  const source = sources[req.params.source]
+
+  if (!source) { throw new Error('404') }
+
+  Promise.resolve(source(req.params.user))
       .then(url => {
         const image = request(url)
         image.on('response', response => {

tests/send404onNonExistingSource.test.js

@@ -0,0 +1,12 @@
+const test = require('ava')
+const supertest = require('supertest')
+
+const app = require('./../src/app')
+
+test('Should send 404 on non existent source wothout invoking next error handlers', async t => {
+  const res = await supertest(app)
+    .get('/non-existent-source/terales')
+
+  t.is(res.statusCode, 404)
+  t.deepEqual(res.body, {})
+})