Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index selector weekly fix #78

Merged
merged 2 commits into from
Jul 15, 2019
Merged

index selector weekly fix #78

merged 2 commits into from
Jul 15, 2019

Conversation

ciorg
Copy link
Member

@ciorg ciorg commented Jul 15, 2019

  • week count is weeks from start of epoch time
  • supporting tests
  • bumped version

@codecov
Copy link

codecov bot commented Jul 15, 2019 •
edited
Loading

Codecov Report

Merging #78 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   76.48%   76.38%   -0.11%     
==========================================
  Files          13       13              
  Lines         927      923       -4     
==========================================
- Hits          709      705       -4     
  Misses        218      218
Impacted Files Coverage Δ
asset/elasticsearch_index_selector/index.js 81.17% <100%> (-0.85%) ⬇️

kstaken
kstaken approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@kstaken kstaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ciorg ciorg merged commit ede9383 into master Jul 15, 2019
@peterdemartini peterdemartini deleted the weekly-index-fix branch August 16, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kstaken kstaken kstaken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ciorg @kstaken