Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a multistage docker image from a debian-bookworm base #3520

Merged
merged 7 commits into from
Jan 11, 2024

Conversation

busma13
Copy link
Contributor

@busma13 busma13 commented Jan 10, 2024

This PR makes the following changes:

  • Rewrite docker file:
    • Discontinue use of base-docker-image
    • Create a multi-stage build:
      • base stage:
        • build image from debian-bookworm
        • combine functionality from the base-docker-image with the yarn build step to create /app directory
      • second stage:
        • build image from debian-bookworm-slim
        • copy /app artifact from base stage, minimizing dependencies
  • Copy the following scripts from base-docker-image repo to teraslice/scripts:
    • docker-pkg-fix.sh (this doesn't seem to be used anywhere)
    • wait-for-it.sh

ref: #3518

@godber
Copy link
Member

godber commented Jan 10, 2024

That seemed too easy, what did you do wrong ;)?

Dockerfile Outdated Show resolved Hide resolved
@busma13 busma13 changed the title New ts docker image Create a multistage docker image from a debian-bookworm base Jan 11, 2024
@busma13 busma13 marked this pull request as ready for review January 11, 2024 19:38
@busma13 busma13 requested a review from godber January 11, 2024 19:55
Copy link
Member

@godber godber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline requests

Dockerfile Outdated Show resolved Hide resolved
scripts/docker-pkg-fix.js Show resolved Hide resolved
busma13 and others added 2 commits January 11, 2024 13:40
Co-authored-by: Austin Godber <godber@terascope.io>
Co-authored-by: Austin Godber <godber@terascope.io>
@busma13 busma13 requested a review from godber January 11, 2024 21:36
@godber godber merged commit 9a44c8e into master Jan 11, 2024
39 checks passed
@godber godber deleted the new-ts-docker-image branch January 11, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants