@Compare don't display error message for left property in certain cases

[yoshikawaa]

Description

For example set as follows, if use @Compare with attribute requiredBoth is true and node is PROPERTY (default).

@Compare(left = "email", right = "confirmEmail",
    operator = Compare.Operator.EQUAL,
    requireBoth = true)
public class UserRegisterForm {
    private String email;
    private String confirmEmail;
}

When either left property or right property is null, error message is not desplayed.
Because error message is desplayed as ROOT_BEAN message unintentionally.

Possible Solutions

https://github.com/terasolunaorg/terasoluna-gfw/blob/master/terasoluna-gfw-common-libraries/terasoluna-gfw-validator/src/main/java/org/terasoluna/gfw/common/validator/constraintvalidators/CompareValidator.java#L100
Also in the case of that (leftValue == null && rightValue == null) return false, it should be called CompareValidator#constructValidationMessage.

Affects Version/s

• 5.1.0.RELEASE and later

Fix Version/s

• 5.3.0
• 5.2.1
• 5.1.2

Issue Links

• #XXX

[kazuki43zoo]

Hi @btyoshikawaa , Are there not need a modification on the integration test ?

[kazuki43zoo]

@yoshikawaa

ping for about above question.

[yoshikawaa]

@kazuki43zoo
I think that the E2E test is unnecessary, because unit test can ensure sufficient code quality for this problem.

[kazuki43zoo]

@yoshikawaa

OK !