-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@Compare don't display error message for left property in certain cases #634
Comments
yoshikawaa
pushed a commit
that referenced
this issue
Dec 12, 2016
yoshikawaa
added a commit
that referenced
this issue
Dec 12, 2016
Modify error message output node in @Compare requireBoth check.#634
This was referenced Dec 12, 2016
yoshikawaa
pushed a commit
that referenced
this issue
Dec 12, 2016
(cherry picked from commit ccfdf8b)
yoshikawaa
added a commit
that referenced
this issue
Dec 12, 2016
…_for_5.2.x [5.2.x]Modify error message output node in @Compare requireBoth check.#634
yoshikawaa
pushed a commit
that referenced
this issue
Dec 12, 2016
(cherry picked from commit ccfdf8b)
yoshikawaa
added a commit
that referenced
this issue
Dec 12, 2016
…_for_5.1.x [5.1.x]Modify error message output node in @Compare requireBoth check.#634
Hi @btyoshikawaa , Are there not need a modification on the integration test ? |
ping for about above question. |
@kazuki43zoo |
OK ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
For example set as follows, if use
@Compare
with attributerequiredBoth
istrue
andnode
isPROPERTY
(default).When either left property or right property is null, error message is not desplayed.
Because error message is desplayed as
ROOT_BEAN
message unintentionally.Possible Solutions
https://github.com/terasolunaorg/terasoluna-gfw/blob/master/terasoluna-gfw-common-libraries/terasoluna-gfw-validator/src/main/java/org/terasoluna/gfw/common/validator/constraintvalidators/CompareValidator.java#L100
Also in the case of that
(leftValue == null && rightValue == null)
returnfalse
, it should be calledCompareValidator#constructValidationMessage
.Affects Version/s
Fix Version/s
Issue Links
The text was updated successfully, but these errors were encountered: