Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correctly highlight initial Select value #28

Merged
merged 2 commits into from
Mar 1, 2018
Merged

Fix: Correctly highlight initial Select value #28

merged 2 commits into from
Mar 1, 2018

Conversation

lukeed
Copy link
Collaborator

@lukeed lukeed commented Mar 1, 2018

Both initial and cursor are 0 by default and index-based. Use the initial value to set the initial cursor position, which fixes the formatting.

Also added *.lock to gitignore to keep all yarn & package lock files out of repo~


Closes #24

@tunnckoCore
Copy link

Why hiding lockfiles? And npm's is package-lock.json ;d

@lukeed
Copy link
Collaborator Author

lukeed commented Mar 1, 2018

Because they suck and weren't included to begin with. All they do is add noise in PRs.

@terkelg
Copy link
Owner

terkelg commented Mar 1, 2018

Thanks a lot @lukeed!

@terkelg terkelg merged commit cae7169 into terkelg:master Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select prompt: Problems & more friendlier initial
3 participants