Small fix to support aarch64. #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert casts to *i8 to *std::os::raw::c_char. see terminusdb-labs#34
|
Thanks a bunch! Interesting to see that chars are apparently not i8 on aarch, or at least not generated as such by bindgen. @rrooij it'd be nice if we could have aarch in our CI, cause there's a big chance I'm inevitably going to screw this up again, given that i do not have any aarch hardware. Is that possible? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests pass on both x86 and arm after the change.
To get tests and cargo-swipl to build nixos I also had to specify the link path like so
but I expect on a regular system they will just work.
I was able to patch this into terminusdb and everything appears to be working.