Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer deletion #59

Open
matko opened this issue Apr 1, 2021 · 0 comments
Open

Layer deletion #59

matko opened this issue Apr 1, 2021 · 0 comments
Labels
difficulty:easy good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@matko
Copy link
Member

matko commented Apr 1, 2021

Layers can't actually be deleted right now. There are many cases when this'd be desirable.

Problems with deleting layers is that someone may be using it, and rely on its existence, which is not something store can really know. Therefore this operation would be a little bit unsafe. Still, it needs to be provided because systems building on top of store may know conditions under which layer deletion is safe.

Besides the layer deletion operation itself, code should be changed to ensure an unexpected missing layer returns an error, rather than crash the server. An unexpected missing layer may occur when

  • it is the parent of an existing layer that we're loading
  • it is pointed at by a label file
  • it is pointed at by a rollup file

These cases should check properly for the existence of a layer and not panic.

@github-actions github-actions bot added the triage issue to be triage label Apr 1, 2021
@Cheukting Cheukting removed the triage issue to be triage label Apr 6, 2021
@Cheukting Cheukting added difficulty:easy good first issue Good for newcomers help wanted Extra attention is needed labels May 17, 2021
@matko matko added this to the v0.20 milestone Sep 17, 2021
@spl spl unassigned matko Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:easy good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants