Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate terminus_store_prolog directly into TerminusDB #1160

Merged
merged 5 commits into from
May 9, 2022
Merged

Conversation

matko
Copy link
Member

@matko matko commented May 5, 2022

This pull request directly integrates store into TerminusDB, allowing reuse of blob types.

It pulls in the relevant source code from terminus_store_prolog, allowing us to drop this dependency. This also means the container now builds directly on top of the swipl container, rather than on top of the terminus_store_prolog container.

@matko matko marked this pull request as ready for review May 9, 2022 13:54
@matko matko enabled auto-merge (rebase) May 9, 2022 13:55
@matko matko disabled auto-merge May 9, 2022 13:56
@matko matko marked this pull request as draft May 9, 2022 13:56
@matko matko marked this pull request as ready for review May 9, 2022 14:34
@matko
Copy link
Member Author

matko commented May 9, 2022

I pre-squashed a whole bunch of commits to make this somewhat easier to review. There's now 3 commits with changes.

  1. Alter the build to include building terminus_store_prolog (taken in from a git repo, not yet merged into the source), and set up the environment to make use of it.
  2. Actually pull in all of the terminus_store_prolog source directly
  3. Update the Dockerfile to build on top of the swipl container, instead of the terminus_store_prolog container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pull terminus_store_prolog source directly into terminusdb
2 participants