Create Utility to get Bytes of a Layer. #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Merged though #96. Thanks! |
CodeMan99
added a commit
to CodeMan99/tyedev
that referenced
this pull request
Apr 19, 2024
🎉 Use of my own contribution @see termoshtt/ocipkg#94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #93 - I was reaching for the wrong abstraction.
Why
I want to be able to work with arbitrary layers. The custom layer types of devcontainers specifically.
Provide
It seems like providing the bytes of a given layer is the least opinionated way to handle this.
Additional
This uses
oci_spec::image::MediaTypeas the callback argument for filtering. Worth considering exposing that value for easier usage.