Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow view pdf file in termux #1872

Closed
Frischid opened this issue Jan 4, 2021 · 3 comments
Closed

Allow view pdf file in termux #1872

Frischid opened this issue Jan 4, 2021 · 3 comments

Comments

@Frischid
Copy link

Frischid commented Jan 4, 2021

Feature description

First of all: Thank you for this nice, helpful app!

I use termux to convert pdf files to svg to view and edit them with another app. It all works quiet well except that I needed to change the manifest to be able to "view" the files directly and convert them with termux.

For my personal use case it would be great being able to "view" pdf files with termux.

Reference implementation
Would be quiet simple to implement, we need to add this line to AndroidManifest.xml:
<data android:mimeType="application/*" /> or better: <data android:mimeType="application/pdf" />

.
.
.
<intent-filter tools:ignore="AppLinkUrlError">
                <action android:name="android.intent.action.VIEW"/>
                <category android:name="android.intent.category.DEFAULT" />
                <data android:mimeType="text/*" />
                <data android:mimeType="application/pdf" />
                <data android:mimeType="application/*log*" />
                <data android:mimeType="application/json" />
                <data android:mimeType="application/*xml*" />
                <data android:mimeType="application/*latex*" />
                <data android:mimeType="application/javascript" />
            </intent-filter>
.
.
.
@ghost
Copy link

ghost commented Jan 4, 2021

I guess it would be better to use <data android:mimeType="application/*" /> rather than adding individual file types.

@ghost ghost added the enhancement label Jan 4, 2021
@ghost ghost closed this as completed in 9228982 Jan 6, 2021
@Frischid
Copy link
Author

Very fast! Thank you!

@bassmadrigal
Copy link

Any chance this can be optional? I'm not terribly familiar with Android development, but I'm thinking it's only changeable at your level and not something you can make optional within the app.

I open PDFs a lot and I'm not presented an option to make a certain app default with PDFs, so I am presented the selector every time I try to open one, which can be a little frustrating (first world problems, I know).

@ghost ghost locked and limited conversation to collaborators Oct 17, 2021
AdamMickiewich pushed a commit to VolyaTeam/dzida-app that referenced this issue Aug 8, 2022
shrihankp pushed a commit to reisxd/termux-app that referenced this issue Oct 20, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants