Cursor styles

[suhan-paradkar]

Feature description

Well, the recent v0.113 did implement 'blinking cursor' ,well this is a request to add additional cursor options, like backslash cursor or underscore as a cursor.
I would like to contribute for this feature....

Reference implementation

Does another app/terminal emulator have this feature?
Provide links to more background information.

[agnostic-apollo]

I thought about adding that, but it could already be done with .bashrc. Check TerminalTest.

• block: echo -e "\033[2 q"
• underline: echo -e "\033[4 q"
• bar: echo -e "\033[6 q"

If we had to add that in termux app itself, then it would require

• Defining a key and internal values, map, default value TerminalEmulator.DEFAULT_CURSOR_STYLE in TermuxPropertyConstants.
• Add Integer getTerminalCursorStyleInternalPropertyValueFromValue(String value) and Integer getTerminalCursorStyle() methods in TermuxSharedProperties to get the value.
• Add DEFAULT_CURSOR_STYLE = CURSOR_STYLE_BLOCK to TerminalEmulator.
• Get that properties value in TerminalEmulator.reset() with the TerminalSessionClient mClient if mClient is not null. Ideally add TerminalEmulator.setCursorStyle() method and call it in reset().
• Which would require adding the interface method Integer getTerminalCursorStyle() to TerminalSessionClient which returns an Integer, not an int.
• Add default implementation to TermuxTerminalSessionClientBase which returns null (which TerminalEmulator should check to default to DEFAULT_CURSOR_STYLE).
• Add termux actual implementation in TermuxTerminalSessionClient which returns mActivity.getProperties().getTerminalCursorStyle().

Hope that's clear enough. Check the previous commits to the files to see how it should be done, like 31298b8 or e4e638b. Make sure to add javadocs and also comments where appropriate.

[suhan-paradkar]

@agnostic-apollo yeah I saw a few lines of code which indicated that it was a WIP..