Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If keyboard toggle is enable/disable, the toggle doesn't work properly after leaving and opening the app #2112

Closed
trygveaa opened this issue Jun 5, 2021 · 0 comments · Fixed by #2114
Closed

If keyboard toggle is enable/disable, the toggle doesn't work properly after leaving and opening the app #2112

trygveaa opened this issue Jun 5, 2021 · 0 comments · Fixed by #2114
Labels
bug report

Comments

@trygveaa
Copy link
Contributor

trygveaa commented Jun 5, 2021

Problem description
If you use the option to enable/disable the keyboard and back out of the app with the keyboard disabled, it can't be enabled with the keyboard toggle alone when entering the app again.

Steps to reproduce

  1. Set soft-keyboard-toggle-behaviour = enable/disable.
  2. Press the toggle to disable the keyboard.
  3. Press back to leave (but not exit) the app.
  4. Return to the app by pressing it in recent apps or the launcher.
  5. Press the keyboard toggle to open the keyboard again.

Expected behavior
The keyboard should open when I press the toggle. Currently nothing happens. To open the keyboard I have to press the terminal view after pressing the toggle.

  • Termux application version: 0.113
  • Android OS version: 11
  • Device model: OnePlus 9 Pro
@agnostic-apollo agnostic-apollo mentioned this issue Jun 5, 2021
Closed
agnostic-apollo added a commit to agnostic-apollo/termux-app that referenced this issue Jun 6, 2021
@agnostic-apollo
Fix issue where soft keyboard would not show in some cases
5ad24c4 
1. If `soft-keyboard-toggle-behaviour=enable/disable` was set, then pressing keyboard toggle wouldn't show the keyboard after switching back from another app if keyboard was previously disabled by user.
2. If switching back from another app, like when opening url with context menu "Select URL" long press and returning to termux with back button, then soft keyboard wouldn't automatically open like it does on app startup.

Fixes termux#2111, Fixes termux#2112
@agnostic-apollo agnostic-apollo mentioned this issue Jun 6, 2021
Merged
agnostic-apollo added a commit to agnostic-apollo/termux-app that referenced this issue Jun 6, 2021
@agnostic-apollo
Fix issue where soft keyboard would not show in some cases
54513e3 
1. If `soft-keyboard-toggle-behaviour=enable/disable` was set, then pressing keyboard toggle wouldn't show the keyboard after switching back from another app if keyboard was previously disabled by user.
2. If switching back from another app, like when opening url with context menu "Select URL" long press and returning to termux with back button, then soft keyboard wouldn't automatically open like it does on app startup.

Also fixed issue where OnFocusChangeListener wasn't being set up if keyboard had to be hidden or disabled on startup.

Fixes termux#2111, Fixes termux#2112
agnostic-apollo added a commit to agnostic-apollo/termux-app that referenced this issue Jun 6, 2021
@agnostic-apollo
Fix issue where soft keyboard would not show in some cases
1ad038e 
1. If `soft-keyboard-toggle-behaviour=enable/disable` was set, then pressing keyboard toggle wouldn't show the keyboard after switching back from another app if keyboard was previously disabled by user.
2. If switching back from another app, like when opening url with context menu "Select URL" long press and returning to termux with back button, then soft keyboard wouldn't automatically open like it does on app startup.

Also fixed issue where OnFocusChangeListener wasn't being set up if keyboard had to be hidden or disabled on startup.

Fixes termux#2111, Fixes termux#2112
AdamMickiewich pushed a commit to VolyaTeam/dzida-app that referenced this issue Aug 8, 2022
@agnostic-apollo
Fix issue where soft keyboard would not show in some cases
2c9b783 
1. If `soft-keyboard-toggle-behaviour=enable/disable` was set, then pressing keyboard toggle wouldn't show the keyboard after switching back from another app if keyboard was previously disabled by user.
2. If switching back from another app, like when opening url with context menu "Select URL" long press and returning to termux with back button, then soft keyboard wouldn't automatically open like it does on app startup.

Also fixed issue where OnFocusChangeListener wasn't being set up if keyboard had to be hidden or disabled on startup.

Fixes termux#2111, Fixes termux#2112
shrihankp pushed a commit to reisxd/termux-app that referenced this issue Oct 20, 2022
@agnostic-apollo
Fix issue where soft keyboard would not show in some cases
5754832 
1. If `soft-keyboard-toggle-behaviour=enable/disable` was set, then pressing keyboard toggle wouldn't show the keyboard after switching back from another app if keyboard was previously disabled by user.
2. If switching back from another app, like when opening url with context menu "Select URL" long press and returning to termux with back button, then soft keyboard wouldn't automatically open like it does on app startup.

Also fixed issue where OnFocusChangeListener wasn't being set up if keyboard had to be hidden or disabled on startup.

Fixes termux#2111, Fixes termux#2112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue where soft keyboard would not show in some cases agnostic-apollo/termux-app
2 participants
@trygveaa @agnostic-apollo