Replace \n with \r when pasting (Fixes #678) #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Termux will now properly send \r to the terminal instead of \n when pasting multiline strings. This fixes cat not repeating back lines and nano accidentally justifying text (because \n maps to ^J), as well as other potential issues. This matches the behavior of other terminals, such as iTerm2 which explicitly does it here: https://github.com/gnachman/iTerm2/blob/f8a5930/sources/iTermPasteHelper.m#L113 Signed-off-by: easyaspi314 (Devin) <easyaspi314@users.noreply.github.com>
ghost
mentioned this pull request
|
Thanks! Should perhaps |
This should replace both \r\n and \n with \r now. "\r?\n" matches 0 or 1 \r and one \n, which should capture both escape sequences.
|
This should do. Didn't want to build the whole thing, but I did a quick test: String str = "\r \r\n \n";
String str2 = str.replaceAll("\r?\n", "\r");
if ("\r \r \r".equals(str2))
System.out.println("PASS"); |
|
Thanks a lot! This will be available in a v0.61 update which will be available shortly. |
|
This has been fixed in version 0.61 of the app, which has now been released and should be available in Google Play within a few hours (and on F-Droid within a day or so)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Termux will now properly send
\rto the terminal instead of\nwhen pasting multiline strings.This fixes
catnot repeating back lines andnanoaccidentally justifying text (because\nmaps to^J), as well as other potential issues.This matches the behavior of other terminals, such as iTerm2 which explicitly does it here:
https://github.com/gnachman/iTerm2/blob/f8a5930/sources/iTermPasteHelper.m#L113