Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libicu: Bumping to 73.1 #16222

Closed
xtkoba opened this issue Apr 16, 2023 · 15 comments
Closed

libicu: Bumping to 73.1 #16222

xtkoba opened this issue Apr 16, 2023 · 15 comments
Labels
information Informational post

Comments

@xtkoba
Copy link
Contributor

xtkoba commented Apr 16, 2023

libicu is now bumping to 73.1. Revdeps are split into several pushes and are being rebuilt. Inconsistencies in bindist can happen but are expected to be resolved within few hours in the main bindist server. Please refrain from filing individual bugs for that. Those bug reports that do not mention this issue will be immedately closed as duplicates.

Also please refrain from pushing commits that modify bindist while CIs for libicu and revdeps are running, to avoid build failure in CI.

Sorry for your inconvenience and thanks for your understanding.

@xtkoba xtkoba added the information Informational post label Apr 16, 2023
@landfillbaby
Copy link
Member

shouldn't you have actually waited for libicu to finish building before pushing the separate revdeps? i think they're downloading the old one

@xtkoba
Copy link
Contributor Author

xtkoba commented Apr 16, 2023

@landfillbaby CI does not work that way. The new version of libicu is always built at first.

@landfillbaby
Copy link
Member

oh so it's just being built 5 times then?

@xtkoba
Copy link
Contributor Author

xtkoba commented Apr 16, 2023

Exactly.

@landfillbaby
Copy link
Member

landfillbaby commented Apr 16, 2023

ah you're right i just checked. still, waiting for it to build once before pushing the revdeps would have been better i think. for next time

@xtkoba
Copy link
Contributor Author

xtkoba commented Apr 16, 2023

That would increase the chance that the aforementioned incosistencies could happen. For example, thorough upgrading after libicu is built but before firefox would break firefox.

@xtkoba
Copy link
Contributor Author

xtkoba commented Apr 16, 2023

So I tried to synchronize the upload timing of revdeps as much as possible, preferebly within 30 minutes. Other maintainers are not expected to do that though. I'm aware it is kind of overkill.

@thunder-coding
Copy link
Member

Also please refrain from pushing commits that modify bindist while CIs for libicu and revdeps are running, to avoid build failure in CI.

I assume that by "bindist" you mean aptly's apt repository on the server. And anyways, this is not a problem at all, we have been having parallel commits modifying various packages and having uploads, usually only the upload step of the CI fails that too only if by coincidence multiple upload jobs happen at same time (which is rare), which can be re-run, and things work as expected without any inconsistencies

@xtkoba
Copy link
Contributor Author

xtkoba commented Apr 16, 2023

@xtkoba
Copy link
Contributor Author

xtkoba commented Apr 16, 2023

Excerpt from the build log:

2023-04-15T17:54:12.6473972Z termux - build of 'qt5-qtbase' done
2023-04-15T17:54:12.6999208Z termux - building qt5-qtdeclarative for arch arm...
2023-04-15T17:54:12.7115317Z Downloading https://packages-cf.termux.dev/apt/termux-main/dists/stable/Release
2023-04-15T17:54:12.7209008Z   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
2023-04-15T17:54:12.7209380Z                                  Dload  Upload   Total   Spent    Left  Speed
2023-04-15T17:54:12.7209944Z 
2023-04-15T17:54:12.8412723Z   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
2023-04-15T17:54:12.8413418Z 100 13134  100 13134    0     0   106k      0 --:--:-- --:--:-- --:--:--  106k
2023-04-15T17:54:12.8481339Z Downloading https://packages-cf.termux.dev/apt/termux-main/dists/stable/Release.gpg
2023-04-15T17:54:12.8535560Z   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
2023-04-15T17:54:12.8536179Z                                  Dload  Upload   Total   Spent    Left  Speed
2023-04-15T17:54:12.8536375Z 
2023-04-15T17:54:13.1398028Z   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
2023-04-15T17:54:13.1398482Z 100   833  100   833    0     0   2954      0 --:--:-- --:--:-- --:--:--  2964
2023-04-15T17:54:13.1464715Z gpg: Signature made Sat 15 Apr 2023 05:53:48 PM UTC
2023-04-15T17:54:13.1465345Z gpg:                using RSA key CC72CF8BA7DBFA0182877D045A897D96E57CF20C
2023-04-15T17:54:13.1471699Z gpg: BAD signature from "Termux Releases (Termux automatic builds) <contact@termux.dev>" [ultimate]
2023-04-15T17:54:13.1494540Z ERROR: failed to verify gpg signature of /home/builder/.termux-build/_cache/packages-cf.termux.dev-apt-termux-main-stable-Release
2023-04-15T17:54:13.2778668Z ##[error]Process completed with exit code 1.

We suffer from this from time to time.

@xtkoba
Copy link
Contributor Author

xtkoba commented Apr 16, 2023

As you see this "interference" by other pushes only happens when starting build of a package, and does not happen after the build of the last package in CI starts successfully, which now is the case with the CIs for libicu and revdeps mentioned here.

So maintainers are now safe to push commits, even though not all CIs are finished. Thanks.

@DarremMolko
Copy link

Hi. I was told to report this here (from the Telegram group):

Setting up nodejs-lts (18.14.1-1) ...
CANNOT LINK EXECUTABLE "node": library "libicui18n.so.73" not found
dpkg: error processing package nodejs-lts (--configure):
 installed nodejs-lts package post-installation script subprocess returned error exit status 1

It happens when trying to upgrade nodejs-lts.

@xtkoba
Copy link
Contributor Author

xtkoba commented Apr 16, 2023

@DarremMolko Yes, this is a typical instance of inconsistencies. Please wait for a while. Thanks.

@xtkoba
Copy link
Contributor Author

xtkoba commented Apr 16, 2023

CI has completed. Note that it will take some time for mirrors to reflect the change. Please use the main server (temporarily) if necessary. Thanks.

Keeping this open for a while.

@xtkoba xtkoba closed this as completed Apr 16, 2023
@landfillbaby
Copy link
Member

landfillbaby commented Apr 16, 2023

a way to avoid this issue in future would be a refactor to separate downloading in the builds to a separate job, and mess with the github actions concurrency so as well as the current way of only allowing one upload at a time, the uploads and downloads are mutually exclusive.
or somehow set the server itself to do a similar thing
no idea how to do either of those though. major refactor of the entire build system, or mess with the aptly api
update: aptly-dev/aptly#1125 might be the whole problem ???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
information Informational post
Projects
None yet
Development

No branches or pull requests

4 participants