Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate instantiating a derived Image class with multiple options #747

Closed
nishakm opened this issue Jun 25, 2020 · 2 comments · Fixed by #750
Closed

Deprecate instantiating a derived Image class with multiple options #747

nishakm opened this issue Jun 25, 2020 · 2 comments · Fixed by #750
Milestone
Release 2.2.0

Comments

@nishakm
Copy link
Contributor

nishakm commented Jun 25, 2020 •
edited
Loading

Description
At the time of creating the Image class, it was not known how users usually reference images. Now we know that they mostly reference them either in the repo:tag format or the repo@digest_type:digest format. There is already functionality to parse the two. Hence we do not need to record Image ID. We can just check to see if what is instantiated follows these two formats.

To Do

  1. Modify the Image class to be instantiated with a generic repotag property
  2. Remove the ImageID property
  3. Test functionality

Background
This is related to PR #734

Super Issues
#678
@mukultaneja
Copy link
Contributor

@nishakm, can I take this issue?

@nishakm
Copy link
Contributor Author

nishakm commented Jun 26, 2020

@mukultaneja go for it!

@mukultaneja mukultaneja mentioned this issue Jun 27, 2020
Merged
nishakm pushed a commit that referenced this issue Jun 29, 2020
@mukultaneja
Removing multiple options to instantiate Image class
abf6e91 
This commit does following,
1. Modifies the Image class to be instantiated
with a generic repotag property
2. Removes the ImageID property
3. Modifies the tests appropriately

Resolved: #747

Signed-off-by: mukultaneja <mtaneja@vmware.com>
@rnjudge rnjudge added this to the Release 2.2.0 milestone Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 2.2.0
Development

Successfully merging a pull request may close this issue.

Removing multiple options to instantiate Image class
3 participants
@nishakm @rnjudge @mukultaneja