-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognize install snippets that follow environment variable declarations #770
Comments
This is kind of bug for now, because our parser will consider
|
I can take on this issue! @rnjudge
Note that this method only works on the condition that the |
@ForgetMe17 do you still want to work on this? |
@nishakm I will try on it! |
This commit modifies parse_shell_variables_and_command() in tern\utils\general.py to enable shell script parser to capture variable assignments before a command. Fixes tern-tools#770. Signed-off-by: WangJL <hazard15020@gmail.com>
This commit modifies parse_shell_variables_and_command() in tern\utils\general.py to enable shell script parser to capture variable assignments before a command. Fixes tern-tools#770. Signed-off-by: WangJL <hazard15020@gmail.com>
This commit modifies parse_shell_variables_and_command() in tern\utils\general.py to enable shell script parser to capture variable assignments before a command. Fixes #770. Signed-off-by: WangJL <hazard15020@gmail.com>
Describe the Feature
It is common in Dockerfiles that build go apps to set some environment variables before running the actual snippet that might install go modules. For example:
For the above line, Tern currently does not recognize "go build" as a snippet to install modules, despite that snippet being listed in snippets.py. This issue proposes changes to the way Tern parses
Use Cases
See golang example above.
Implementation Changes
Changes to
filter_install_commands()
or other associated functions, likesplit_command()
, to better filter through potential environment variables that might come before a snippet install command.The text was updated successfully, but these errors were encountered: