Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updates aws provider to at least 3.0.0 #4

Merged

Conversation

mike-carey
Copy link
Contributor

@mike-carey mike-carey commented Oct 12, 2020

Description

Bumps the aws provider version due to a rename of cloudfront distribution property.

Motivation and Context

See #3

Breaking Changes

Anyone using this module with < 3.0 should not be able to plan anyways.

How Has This Been Tested?

When attempting to use the module, I stumbled upon this. See #3 for a test file you can dump into a temp directory and run terraform init and plan. When using the file as is, the error can be observed. When the provider version is updated to 3.0, no error is provided.

@mike-carey mike-carey changed the title Updates aws provider to at least 3.0.0 fix: Updates aws provider to at least 3.0.0 Oct 12, 2020
@antonbabenko antonbabenko merged commit d62fc9d into terraform-aws-modules:master Oct 12, 2020
@antonbabenko
Copy link
Member

Thanks, @mike-carey !

v1.1.0 has been just released.

@mike-carey mike-carey deleted the provider-version branch October 12, 2020 20:02
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants