Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support for CloudFront Functions #41

Merged
merged 6 commits into from
May 28, 2021

Conversation

ricoli
Copy link
Contributor

@ricoli ricoli commented May 28, 2021

Description

Adds support for CloudFront Functions - Terraform docs at https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudfront_distribution#function-association

Motivation and Context

Supporting new functionality

Breaking Changes

None

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
    I'm in the process of testing this in a private project, but I'm opening this PR already for some feedback

@ricoli ricoli changed the title Support for CloudFront Functions feat: Support for CloudFront Functions May 28, 2021
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update versions.tf with the minimum version of Terraform AWS provider where this feature was introduced, and run example code yourself to verify this code.

main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
examples/complete/main.tf Outdated Show resolved Hide resolved
examples/complete/main.tf Outdated Show resolved Hide resolved
main.tf Show resolved Hide resolved
@ricoli
Copy link
Contributor Author

ricoli commented May 28, 2021

I've successfully applied the complete example as of my last commit

@antonbabenko antonbabenko merged commit 32faee5 into terraform-aws-modules:master May 28, 2021
@antonbabenko
Copy link
Member

Thanks, Ricardo!

v2.5.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants