Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated handling of one or many custom_error_response values #89

Merged
merged 1 commit into from
Nov 14, 2022
Merged

fix: Updated handling of one or many custom_error_response values #89

merged 1 commit into from
Nov 14, 2022

Conversation

antonbabenko
Copy link
Member

@antonbabenko antonbabenko commented Nov 14, 2022 •
edited

Fixes #88

Valid inputs:

  custom_error_response = {
    error_code         = 404
    response_page_path = "/errors/404.html"
  }

or

  custom_error_response = [{
    error_code         = 404
    response_page_path = "/errors/404.html"
  }, {
    error_code         = 403
    response_page_path = "/errors/403.html"
  }
  ]

@antonbabenko antonbabenko merged commit 0945c77 into master Nov 14, 2022
@antonbabenko antonbabenko deleted the fix-custom-error-code branch November 14, 2022 14:41
antonbabenko pushed a commit that referenced this pull request Nov 14, 2022
@semantic-release-bot
chore(release): version 3.0.2 [skip ci]
2fd7f3f 
### [3.0.2](v3.0.1...v3.0.2) (2022-11-14)

### Bug Fixes

* Updated handling of one or many custom_error_response values ([#89](#89)) ([0945c77](0945c77))
@antonbabenko
Copy link
Member Author

This PR is included in version 3.0.2 🎉

@zahorniak zahorniak mentioned this pull request Nov 14, 2022
Closed
1 task
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

custom_error_response dynamic block does not work
1 participant
@antonbabenko