Question/Problem with docker_image input

[JCapriotti]

Description

I'm wondering why specifying docker_image inconsistently requires either docker_build_root or docker_file to be provided. It seems that docker_image works without the other inputs only if the image is already stored locally.

Versions

• Terraform:

  Terraform v1.0.9
  on darwin_amd64
  

• Providers:

  + provider registry.terraform.io/cyrilgdn/postgresql v1.14.0
  + provider registry.terraform.io/hashicorp/aws v3.61.0
  + provider registry.terraform.io/hashicorp/external v2.1.0
  + provider registry.terraform.io/hashicorp/http v2.1.0
  + provider registry.terraform.io/hashicorp/local v2.1.0
  + provider registry.terraform.io/hashicorp/null v3.1.0
  + provider registry.terraform.io/hashicorp/random v3.1.0
  

• Module:

  2.22.0
  

Reproduction

Using these Docker-related inputs (no other docker inputs) AND if you have not pulled the Docker image locally.

build_in_docker   = true
docker_image      = "public.ecr.aws/sam/build-python3.9:latest"

Expected behavior

The Docker image is used for the packaging without error.

Actual behavior

Error:

ValueError: docker_build_root or docker_file must be provided

Terminal Output Screenshot(s)

Additional context

This seems to be caused by a call to docker images <tag>.

If the image is found, ok is set to True and docker_build_command is (correctly) never called, which is the method that is raising the error.

This seems like a bug, but I'm not sure of the intent for that block of code.

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

[github-actions]

This issue was automatically closed because of stale in 10 days

[bellis-ai]

This is still a valid problem. Why the image needs to be pre-pulled is beyond me.

[bellis-ai]

If anyone else is encountering this problem and has something like a pipeline where they don't want to add download steps on every apply, use a barebones dockerfile that is "FROM" the image you want

i.e.

FROM "public.ecr.aws/sam/build-python3.9" 

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.