-
-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support building layers in DockerInDocker scenario #352
Conversation
15f160b
to
b0b7694
Compare
This PR has been automatically marked as stale because it has been open 30 days |
@antonbabenko what is needed for the PR to be considered? |
@mwiede I'm at AWS reinvent this and next week, so I can't take a look at this. Usually, when there is a new feature added we need to update example code to show how to use this feature for real. Could you or someone else make necessary changes there? It would help a lot to speed things up. |
This PR has been automatically marked as stale because it has been open 30 days |
This PR was automatically closed because of stale in 10 days |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
We have Jenkins instances running with Docker-In-Docker and there are Pipelines using Docker images as agent. I was facing problems with the docker run commands inside of this package, because the volumes for temporary directories or the current workspace/build-root could not be mounted.
The error, which occured was:
ERROR: Could not open requirements file: [Errno 2] No such file or directory: 'requirements.txt'
Motivation and Context
Give option to make building lambda layer in Docker work in Docker-In-Docker/Jenkins-Docker. To be able to do this, one need to pass the container-id of the parent container to any docker run command in the
--volumes-from
parameter.On Jenkins this is now possible by defining
TF_VAR_docker_volume
as environent variable.Additionally, this PR is fixing #219 by pulling the build image if needed.
Breaking Changes
none.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request