Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support building layers in DockerInDocker scenario #352

Closed
wants to merge 5 commits into from

Conversation

mwiede
Copy link

@mwiede mwiede commented Oct 12, 2022

Description

We have Jenkins instances running with Docker-In-Docker and there are Pipelines using Docker images as agent. I was facing problems with the docker run commands inside of this package, because the volumes for temporary directories or the current workspace/build-root could not be mounted.

The error, which occured was: ERROR: Could not open requirements file: [Errno 2] No such file or directory: 'requirements.txt'

Motivation and Context

Give option to make building lambda layer in Docker work in Docker-In-Docker/Jenkins-Docker. To be able to do this, one need to pass the container-id of the parent container to any docker run command in the --volumes-from parameter.
On Jenkins this is now possible by defining TF_VAR_docker_volume as environent variable.

Additionally, this PR is fixing #219 by pulling the build image if needed.

Breaking Changes

none.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 22, 2022
@mwiede
Copy link
Author

mwiede commented Nov 23, 2022

@antonbabenko what is needed for the PR to be considered?

@antonbabenko
Copy link
Member

@mwiede I'm at AWS reinvent this and next week, so I can't take a look at this.

Usually, when there is a new feature added we need to update example code to show how to use this feature for real. Could you or someone else make necessary changes there? It would help a lot to speed things up.

@github-actions github-actions bot removed the stale label Nov 24, 2022
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 25, 2022
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Jan 5, 2023
@github-actions
Copy link

github-actions bot commented Feb 4, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants