Legacy Incoming Webhooks vs. Slack Apps

[klucks83]

Slack now appears to have the concept of Legacy Incoming Webhooks (https://api.slack.com/legacy/custom-integrations/incoming-webhooks) and new Incoming Webhooks (or Slack Apps - https://api.slack.com/incoming-webhooks).

When setting up an incoming webhook the new way (a Slack App), this TF module still works, however the slack_channel, slack_username, and slack_emoji Terraform inputs no longer appear to be needed and/or modifiable via Lambda, as they are a part of the creation process of a Slack App webhook.

I don't personally have a solution, but wanted to at least bring awareness to this concept and how that may drive future changes to this module.

slack_channel     = "aws-notification"
slack_username    = "reporter"
slack_emoji       = ":thing:"

It is also worth noting that the first 2 sentences of this README now link to each of the Webhook creation methods which could be confusing to people setting up a webhook and using this module for the first time.

• The first sentence links to the new Slack Apps creation process
• The second sentence links to the creation of a legacy Incoming Webhook

[rahulk94]

Ideally we should just use the new Slack App webhook configuration so that the webhook avatar and name are respected.

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

[github-actions]

This issue was automatically closed because of stale in 10 days

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.