Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Added variable to filter body of message on SNS level and bumped min Terraform version to 1.0 #196

Conversation

rysi3k
Copy link
Contributor

@rysi3k rysi3k commented Apr 17, 2023

Description

Add variable for passing filter_policy_scope

Motivation and Context

I want to filter body of message on SNS level.

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label May 18, 2023
@rysi3k
Copy link
Contributor Author

rysi3k commented May 18, 2023

@antonbabenko could you look at this?

@antonbabenko antonbabenko changed the title Add variable for passing filter_policy_scope feat: Added variable to filter body of message on SNS level May 18, 2023
@antonbabenko antonbabenko changed the title feat: Added variable to filter body of message on SNS level feat!: Added variable to filter body of message on SNS level and bumped min Terraform version to 1.0 May 18, 2023
@antonbabenko antonbabenko merged commit ab660f7 into terraform-aws-modules:master May 18, 2023
antonbabenko pushed a commit that referenced this pull request May 18, 2023
## [6.0.0](v5.6.0...v6.0.0) (2023-05-18)

### ⚠ BREAKING CHANGES

* Added variable to filter body of message on SNS level and bumped min Terraform version to 1.0 (#196)

### Features

* Added variable to filter body of message on SNS level and bumped min Terraform version to 1.0 ([#196](#196)) ([ab660f7](ab660f7))
@antonbabenko
Copy link
Member

This PR is included in version 6.0.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants