feat: Add security group egress rule support, fix documentation links #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
changed the title
bryantbiggs
changed the title
antonbabenko
reviewed
Nov 6, 2021
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
antonbabenko
changed the title
|
v6.1.0 has been just released. |
|
Great job, thanks! Will refactor my code to use this now. However, is this making an assumption that egress always needs to connect to either 3306 or 5432? |
|
No, you can override the port in each rule. It just defaults to the cluster port of one is not provided |
DanK-CS
pushed a commit
to usertesting/terraform-aws-rds-aurora
that referenced
this pull request
Nov 18, 2021
* terraform-aws-modules-master: (32 commits) chore: Giving up on releaserc config (for now) (terraform-aws-modules#257) chore(release): version 6.1.3 [skip ci] fix: Revert small useless change in main.tf (terraform-aws-modules#256) chore(release): version 6.1.2 [skip ci] fix: Small useless change in main.tf to test semantic-release (last one, I promise) (terraform-aws-modules#255) fix: Small useless change in main.tf to test semantic-release (terraform-aws-modules#254) chore: Updated .releaserc config and tf file (to trigger release) (terraform-aws-modules#253) chore: Updated .releaserc config (terraform-aws-modules#252) chore(release): version 6.1.1 [skip ci] chore: Added workflow_dispatch to allow manual releases (terraform-aws-modules#251) fix: update CI/CD process to enable auto-release workflow (terraform-aws-modules#250) Updated CHANGELOG feat: Add security group egress rule support, fix documentation links (terraform-aws-modules#249) Updated CHANGELOG chore: Updated release Makefile Updated CHANGELOG BREAKING CHANGE: update module to allow for control over individual cluster instances and latest features (terraform-aws-modules#243) chore: update CI workflow to use composite actions, update pre-commit versions (terraform-aws-modules#242) Updated CHANGELOG feat: Add support for restore_to_point_in_time (terraform-aws-modules#194) ...
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
var.partdefault value changed from""tonull. this change makes the local variable logic work as intended with the new default valueMotivation and Context
Closes #38
Closes #248
Breaking Changes
How Has This Been Tested?
examples/*projectsexamples/postgresqlexample project