Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update CI/CD process to enable auto-release workflow #250

Merged
merged 1 commit into from
Nov 7, 2021
Merged

fix: update CI/CD process to enable auto-release workflow #250

merged 1 commit into from
Nov 7, 2021

Conversation

bryantbiggs
Copy link
Member

Description

Motivation and Context

  • automate release process in a standardized manner
  • standardize new CI workflow (copying from RDS)

Breaking Changes

  • No

How Has This Been Tested?

@antonbabenko antonbabenko merged commit b44aae5 into terraform-aws-modules:master Nov 7, 2021
@bryantbiggs bryantbiggs deleted the chore/update-ci branch November 7, 2021 19:29
@antonbabenko
Copy link
Member

Any ideas why this merge has not triggered the release?

@bryantbiggs
Copy link
Member Author

there were no file patterns matched that would trigger the release workflow - https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/blob/master/.github/workflows/release.yml#L8-L10

@antonbabenko
Copy link
Member

Right, and it does not seem to be possible to trigger workflow manually to force release by running gh workflow run Release (as described here) for the first run:

$ gh workflow run Release 
could not create workflow dispatch event: HTTP 422: Workflow does not have 'workflow_dispatch' trigger (https://api.github.com/repos/terraform-aws-modules/terraform-aws-rds-aurora/actions/workflows/15013535/dispatches)

Good to know.

@antonbabenko
Copy link
Member

Should we add workflow_dispatch as triggers?

@antonbabenko
Copy link
Member

I added it in #251

antonbabenko pushed a commit that referenced this pull request Nov 8, 2021
@semantic-release-bot
chore(release): version 6.1.1 [skip ci]
e692401 
## [6.1.1](v6.1.0...v6.1.1) (2021-11-08)

### Bug Fixes

* update CI/CD process to enable auto-release workflow ([#250](#250)) ([b44aae5](b44aae5))
@antonbabenko
Copy link
Member

🎉 This PR is included in version 6.1.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

DanK-CS pushed a commit to usertesting/terraform-aws-rds-aurora that referenced this pull request Nov 18, 2021
Merge branch 'terraform-aws-modules-master' into fetch_upstream_20211118
a1bcc7b 
* terraform-aws-modules-master: (32 commits)
  chore: Giving up on releaserc config (for now) (terraform-aws-modules#257)
  chore(release): version 6.1.3 [skip ci]
  fix: Revert small useless change in main.tf (terraform-aws-modules#256)
  chore(release): version 6.1.2 [skip ci]
  fix: Small useless change in main.tf to test semantic-release (last one, I promise) (terraform-aws-modules#255)
  fix: Small useless change in main.tf to test semantic-release (terraform-aws-modules#254)
  chore: Updated .releaserc config and tf file (to trigger release) (terraform-aws-modules#253)
  chore: Updated .releaserc config (terraform-aws-modules#252)
  chore(release): version 6.1.1 [skip ci]
  chore: Added workflow_dispatch to allow manual releases (terraform-aws-modules#251)
  fix: update CI/CD process to enable auto-release workflow (terraform-aws-modules#250)
  Updated CHANGELOG
  feat: Add security group egress rule support, fix documentation links (terraform-aws-modules#249)
  Updated CHANGELOG
  chore: Updated release Makefile
  Updated CHANGELOG
  BREAKING CHANGE: update module to allow for control over individual cluster instances and latest features (terraform-aws-modules#243)
  chore: update CI workflow to use composite actions, update pre-commit versions (terraform-aws-modules#242)
  Updated CHANGELOG
  feat: Add support for restore_to_point_in_time (terraform-aws-modules#194)
  ...
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryantbiggs @antonbabenko