Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add output for the CloudWatch log group name and ARN created for the Step Function #45

Merged
merged 3 commits into from
Apr 7, 2023
Merged

feat: Add output for the CloudWatch log group name and ARN created for the Step Function #45

merged 3 commits into from
Apr 7, 2023

Conversation

dod38fr
Copy link
Contributor

@dod38fr dod38fr commented Dec 1, 2022 •
edited
Loading

Description

Add cloudwatch log group name and arn in output. This log group was already created by this module. This PR only adds the output.

Motivation and Context

We need to connect the generated log group to log-metric-filter module using the name and the ARN of the log group created by this module.

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@dod38fr dod38fr changed the title Feat/add cloudwatch log group output feat: add cloudwatch log group output Dec 1, 2022
@dod38fr dod38fr changed the title feat: add cloudwatch log group output feat: Add cloudwatch log group output Dec 1, 2022
@dod38fr
Copy link
Contributor Author

dod38fr commented Dec 20, 2022

Hi

@antonbabenko , is there anything preventing this PR to be merged ?

All the best

@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jan 20, 2023
@dod38fr dod38fr force-pushed the feat/add-cloudwatch-log-group-output branch from 263f59b to 3317944 Compare January 20, 2023 08:12
@dod38fr
Copy link
Contributor Author

dod38fr commented Jan 20, 2023

I've reworked the history to be fully compliant with conventional commit.

Could you review this PR ?

All the best

@github-actions github-actions bot removed the stale label Jan 21, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Feb 20, 2023
@dod38fr
Copy link
Contributor Author

dod38fr commented Feb 20, 2023

Any news ?

@dod38fr dod38fr force-pushed the feat/add-cloudwatch-log-group-output branch from 3317944 to 1337c85 Compare February 20, 2023 09:42
@github-actions github-actions bot removed the stale label Feb 21, 2023
@dod38fr dod38fr changed the title feat: Add cloudwatch log group output feat: Add output for the ARN of the CloudWatch log group created for the Step Function Mar 6, 2023
@dod38fr dod38fr changed the title feat: Add output for the ARN of the CloudWatch log group created for the Step Function feat: Add output for the CloudWatch log group name and ARN created for the Step Function Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Apr 6, 2023
@dod38fr
Copy link
Contributor Author

dod38fr commented Apr 7, 2023

Any news ?

@antonbabenko antonbabenko removed the stale label Apr 7, 2023
@antonbabenko antonbabenko merged commit 62afe34 into terraform-aws-modules:master Apr 7, 2023
antonbabenko pushed a commit that referenced this pull request Apr 7, 2023
@semantic-release-bot
chore(release): version 2.8.0 [skip ci]
e41a2a8 
## [2.8.0](v2.7.3...v2.8.0) (2023-04-07)

### Features

* Add output for the CloudWatch log group name and ARN created for the Step Function ([#45](#45)) ([62afe34](62afe34))
@antonbabenko
Copy link
Member

This PR is included in version 2.8.0 🎉

@github-actions
Copy link

github-actions bot commented May 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dod38fr @antonbabenko