Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix version 6.x and 7.0 in parameter group #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josacar
Copy link

@josacar josacar commented Jan 20, 2023

Right now support for 6.x and 7.0 versions is broken in this module, as it's referencing an non-existing parameter group.

I went to the current AWS versions and I did a mapping with the parameter_group_family :

3.2.4 => redis3.2
3.2.6 => redis3.2
3.2.10 => redis3.2
4.0.10 => redis4.0
5.0.6 => redis5.0
6.0 => redis6.x
6.2 => redis6.x
6.x => redis6.x
7.0 => redis7

This is the tests I performed with the current code in repository:

for version in 3.2.4 3.2.6 3.2.10 4.0.10 5.0.6 6.0 6.2 6.x 7.0; do
     echo "local.parameter_group_family_old" | TF_VAR_redis_version="$version" terraform console
   done

"redis3.2"
"redis3.2"
"redis3.2"
"redis4.0"
"redis5.0"
"redis6.x"
"redis6.x"
"redis6.x.x"
"redis7.x"

As you can see, 6.x and 7.0 versions are wrong ( last two lines )

With my path produces the following result:

for version in 3.2.4 3.2.6 3.2.10 4.0.10 5.0.6 6.0 6.2 6.x 7.0; do
     echo "local.parameter_group_family" | TF_VAR_redis_version="$version" terraform console
   done

"redis3.2"
"redis3.2"
"redis3.2"
"redis4.0"
"redis5.0"
"redis6.x"
"redis6.x"
"redis6.x"
"redis7"

Which matches with the manual mapping in the beginning of the post.

@antonbabenko let me know if you need anything else.

@tomthetommy
Copy link

When is this being merged?

@bergbrains
Copy link

Any chance this can be merged soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants