Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Main.tf Comment Handling on Windows #65

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Fix Main.tf Comment Handling on Windows #65

merged 1 commit into from
Sep 26, 2018

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Sep 26, 2018

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request introduces breaking change.

For more information, see the Contributing Guide.

Description

This pull request changes the method used for extracting the filename from the path to check if main.tf is being processed. The current path package used is not OS agnostic, whereas filepath is. See Package Filepath for further info.

Issues Resolved

#32

Checklist

Put an x into all boxes that apply:

Tests

  • I have added tests to cover my changes.
  • All tests pass when I run make test.

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Code Style

  • My code follows the code style of this project.

@metmajer
Copy link
Member

Great catch, @X-Guardian and thanks for the contribution!

@metmajer metmajer merged commit cffbab4 into terraform-docs:master Sep 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants