add docker multiarch build #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shamil Ganiev <ganiev@pm.me>
|
What is left for this to be merged? |
Signed-off-by: Ganiev Shamil <ganiev@pm.me>
|
It looks like this changes the tags from I think it would be nicer to push multi arch images with the existing tags instead. Edit: I have no idea how goreleaser works, but I guess this might help: https://goreleaser.com/cookbooks/multi-platform-docker-images/#creating-multi-platform-docker-images-with-goreleaser |
|
Hi @pascal-hofmann! The tag is specified a target architecture and it works seamlessly for the end user. You'll continue to pull in the same way by |
pascal-hofmann
approved these changes
Sep 4, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Add Docker multi-arch build
Fixes #712
I have:
make test.