-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloud_sql): add ssl_mode to PostgreSQL example #538
Conversation
/gcbrun |
@feng-zhe - Thank you for sharing testing logs |
/gcbrun |
Hi @msampathkumar, thanks for reviewing the change. I saw the above |
Sorry for the trouble. The CICD is the process of being upgraded and we would have wait for it be completed or this bug to cleared up. |
/gcbrun |
Thanks @msampathkumar! Somehow the CICD still fails and I cannot find anything related to this change. Update: I saw it says my branch is outdated from main. So I just clicked the "update branch" button. Hope it helps. Thanks. |
Hi @msampathkumar , any updates? Please let me know what I should to make the CICD errors go away. Thanks. |
/gcbrun |
Head branch was pushed to by a user without write access
Thanks, I've changed it to |
Hi @msampathkumar, just a friendly ping. Thanks. |
/gcbrun |
Error:
|
I will be doing for manual testing for approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manually tested. LGTM.
3e9f924
into
terraform-google-modules:main
Description
Fixes #310700535
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide: https://paste.googleplex.com/6576073727279104?raw
terraform apply
terraform fmt
checkIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s):
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review