Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Introduce the ssl_mode into the MySQL SSL example #586

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

feng-zhe
Copy link
Contributor

@feng-zhe feng-zhe commented Feb 1, 2024

We have introduced ssl_mode to MySQL instances. Thus its SSL example should be updated too.

Description

Fixes #313530521

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

We have introduced `ssl_mode` to MySQL instances. Thus its SSL example
should be updated too.
@feng-zhe feng-zhe requested review from a team as code owners February 1, 2024 00:58
@feng-zhe
Copy link
Contributor Author

feng-zhe commented Feb 1, 2024

FYI, this is similar to the pull request #538 . Thanks.

@glasnt
Copy link
Contributor

glasnt commented Feb 1, 2024

/gcbrun

@glasnt
Copy link
Contributor

glasnt commented Feb 2, 2024

/gcbrun

@glasnt glasnt enabled auto-merge (squash) February 2, 2024 03:49
@feng-zhe
Copy link
Contributor Author

feng-zhe commented Feb 2, 2024

Hi @glasnt , I see it still shows "Code owner review required" and the merge is still blocked. Do you know how I can get a reviewer assigned to this PR? Thanks.

@glasnt glasnt merged commit b3dcdbc into terraform-google-modules:main Feb 2, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants