Add support for access #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial addition of UDF module
morgante
approved these changes
Feb 14, 2020
There was a problem hiding this comment.
Thanks for the explanation, that now makes more sense and I'm okay with including it. @jaketf just to confirm this is a best practice.
If you get a chance, it'd be nice to add:
- Tests for the
accessparam - A note in the README about how to use access and the default we set.
| # special_group: A special group to grant access to. | ||
| variable "access" { | ||
| description = "An array of objects that define dataset access for one or more entities." | ||
| type = any |
There was a problem hiding this comment.
Note: once hashicorp/terraform#19898 is resolved we should switch to type = list(object)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also set a better default (a single owner which is projectOwners). The defaults of BQ are not very good which is why I made this PR to begin with as we would like to use this module for our e2e solutions. The default BQ adds the calling user as an owner on the dataset which is a big no-no for us (access should only be granted via explicit groups/service accounts or inheritance). This default is much more secure and in line with how other GCP resources work.
I thought it would be ok to improve the default for CFT as better defaults was one of the goals. But if you prefer to avoid diff I can just set this to null as default which shouldn't need a new release.
Fix #12