-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial addition of dataset access module #38
Initial addition of dataset access module #38
Conversation
I'm going to need some help setting up the CI IAM groups & admin email to get these CI tests passing. Not sure who the best person is to talk to about that. |
Need GoogleCloudPlatform/cloud-foundation-toolkit#509 merged to add directory of binaries to ignore linting. |
@milesmatthias Merged the new devtools image. |
Running into #26 (comment), so either need to remove some of the clustering support, or update this feature to require Google v3.0.0 provider. |
Linting will be fixed by GoogleCloudPlatform/cloud-foundation-toolkit#523. |
@morgante would love any thoughts you have here to help unblock me. Thanks! |
@morgante this looks good to go |
@@ -0,0 +1,53 @@ | |||
# Copyright 2019 Google LLC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should have a module-specific Makefile. Instead, could we fold any special commands into the standard module Makefile?
Possibly with custom helpers: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/test/task_helper_functions.sh
We are very interested in this capability to be merged. Is there any ETA on that? |
We also need access control (and encryption). :) Out of interest, why is this done by executing a binary vs setting the |
@morgante this can be closed |
This was fixed by #48. |
Fixes #12.