Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial addition of dataset access module #38

Conversation

milesmatthias
Copy link

@milesmatthias milesmatthias commented Nov 6, 2019

Fixes #12.

@aaron-lane aaron-lane added the enhancement New feature or request label Nov 18, 2019
@aaron-lane aaron-lane mentioned this pull request Nov 18, 2019
examples/dataset_access/main.tf Outdated Show resolved Hide resolved
examples/dataset_access/main.tf Outdated Show resolved Hide resolved
@milesmatthias
Copy link
Author

I'm going to need some help setting up the CI IAM groups & admin email to get these CI tests passing. Not sure who the best person is to talk to about that.

@milesmatthias
Copy link
Author

Need GoogleCloudPlatform/cloud-foundation-toolkit#509 merged to add directory of binaries to ignore linting.

@morgante
Copy link
Contributor

@milesmatthias Merged the new devtools image.

@milesmatthias
Copy link
Author

Running into #26 (comment), so either need to remove some of the clustering support, or update this feature to require Google v3.0.0 provider.

@milesmatthias
Copy link
Author

Linting will be fixed by GoogleCloudPlatform/cloud-foundation-toolkit#523.

@milesmatthias
Copy link
Author

@morgante would love any thoughts you have here to help unblock me. Thanks!

@milesmatthias
Copy link
Author

@morgante this looks good to go

@@ -0,0 +1,53 @@
# Copyright 2019 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have a module-specific Makefile. Instead, could we fold any special commands into the standard module Makefile?

Possibly with custom helpers: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/test/task_helper_functions.sh

@mikhail-khodorovskiy
Copy link

We are very interested in this capability to be merged. Is there any ETA on that?

@06kellyjac
Copy link

We also need access control (and encryption). :)

Out of interest, why is this done by executing a binary vs setting the access block?

@umairidris
Copy link
Contributor

@morgante this can be closed

@umairidris
Copy link
Contributor

This was fixed by #48.

@umairidris umairidris closed this Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control dataset access
6 participants