Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for the use of an alternative service account for GKE cluster nodes #8

Closed
glarizza opened this issue May 8, 2019 · 5 comments
Labels
enhancement New feature or request Stale

Comments

@glarizza
Copy link

glarizza commented May 8, 2019

Currently the module doesn't specify the service_account attribute for the google_container_cluster resource, which means the cluster will attempt to use the default compute service account for the Project ID specified. If you use Project Factory to create the project for this module, PF will delete the default compute SA (which is its own bug terraform-google-modules/terraform-google-project-factory#181 ), and Terraform will give you an error that looks like the following:

* google_container_cluster.gitlab: googleapi: Error 400: Service account "483850288765-compute@developer.gserviceaccount.com" does not exist., badRequest

Surfacing a variable to specify an alternate SA should do fine here.

@aaron-lane
Copy link

This should be labelled as enhancement and added to the Cloud Foundation Toolkit project; I currently lack permissions to do so. 😢

@glarizza
Copy link
Author

I tried to edit and see if I could add the enhancement label, but I don't think I have that ability either

@morgante morgante added the enhancement New feature or request label May 28, 2019
@morgante
Copy link
Contributor

I added the label, but should mention this isn't an official CFT repo. @viglesiasce created this repo and would be the right person to review any PRs.

@aaron-lane
Copy link

Yes, ignore me. I was overzealous in my triage. 😊

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

3 participants