Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a parameter 'registry_project_id' to the GKE module templates #273

Merged
merged 3 commits into from
Oct 18, 2019
Merged

Add a parameter 'registry_project_id' to the GKE module templates #273

merged 3 commits into from
Oct 18, 2019

Commits on Oct 4, 2019

  1. Add a parameter 'registry_project_id' 

    The PR allows configuring the project holding the GCR registry when
used in connection with 'create_service_account'=true and
grant_registry_access=true.

Holding the GCR is a project with other resources increases the risk of
exposing sensitive data to the service account running the nodes, as the
required permissions of role roles/storage.objectViewer provide access
to all storage objects in the project.
    @mmontan
    mmontan committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    55ade20 View commit details
    Browse the repository at this point in the history

  2. Reformatted a file

    @mmontan
    mmontan committed Oct 4, 2019
    Configuration menu
    Copy the full SHA
    bf39469 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. Merge branch 'master' into custom-gcr-project

    @morgante
    morgante committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    e71ef10 View commit details
    Browse the repository at this point in the history